Skip to content

HADOOP-18917. commons-io 2.14.0#6133

Merged
ayushtkn merged 1 commit intoapache:trunkfrom
pjfanning:HADOOP-18917-io
Oct 5, 2023
Merged

HADOOP-18917. commons-io 2.14.0#6133
ayushtkn merged 1 commit intoapache:trunkfrom
pjfanning:HADOOP-18917-io

Conversation

@pjfanning
Copy link
Member

@pjfanning pjfanning commented Sep 30, 2023

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

hadoop-yetus commented Oct 1, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 1s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 13s Maven dependency ordering for branch
+1 💚 mvninstall 20m 50s trunk passed
+1 💚 compile 10m 32s trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚 compile 9m 32s trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚 mvnsite 14m 25s trunk passed
+1 💚 javadoc 5m 53s trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 5m 9s trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚 shadedclient 31m 35s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 29s Maven dependency ordering for patch
+1 💚 mvninstall 18m 24s the patch passed
+1 💚 compile 9m 54s the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚 javac 9m 54s the patch passed
+1 💚 compile 9m 33s the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚 javac 9m 33s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 9m 25s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 5m 47s the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 5m 8s the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚 shadedclient 32m 27s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 661m 33s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 1m 19s The patch does not generate ASF License warnings.
848m 49s
Reason Tests
Failed junit tests hadoop.fs.azurebfs.services.TestTextFileBasedIdentityHandler
hadoop.mapreduce.v2.TestMRJobs
hadoop.mapreduce.v2.TestUberAM
hadoop.mapreduce.v2.TestMRJobsWithProfiler
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6133/1/artifact/out/Dockerfile
GITHUB PR #6133
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux bb70d78bbf3f 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 9256cf0
Default Java Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6133/1/testReport/
Max. process+thread count 3459 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6133/1/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ayushtkn
ayushtkn approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushtkn ayushtkn merged commit 2bf5a9e into apache:trunk Oct 5, 2023
@pjfanning pjfanning deleted the HADOOP-18917-io branch October 5, 2023 20:31
@ayushtkn
Copy link
Member

ayushtkn commented Oct 5, 2023

Ouch!! I think the TestTextFileBasedIdentityHandler is related?

pjfanning added a commit to pjfanning/hadoop that referenced this pull request Oct 5, 2023
@pjfanning
HADOOP-18917. Upgrade to commons-io 2.14.0 (apache#6133). Contributed…
8d92356 
… by PJ Fanning

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
@pjfanning pjfanning mentioned this pull request Oct 5, 2023
Merged
@ayushtkn
Copy link
Member

ayushtkn commented Oct 5, 2023 •
edited
Loading

@pjfanning We have a test failure. (https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6133/1/testReport/org.apache.hadoop.fs.azurebfs.services/TestTextFileBasedIdentityHandler/)
Can you shoot an addendum with the fix. I tried locally this work, else I think we need to revert this, others might get blocked. Sorry, I should have been bit more careful :-(

diff --git a/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestTextFileBasedIdentityHandler.java b/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestTextFileBasedIdentityHandler.java
index f9950faf944..66614ddb3fd 100644
--- a/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestTextFileBasedIdentityHandler.java
+++ b/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestTextFileBasedIdentityHandler.java
@@ -22,6 +22,7 @@
 import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.nio.charset.Charset;
+import java.nio.file.NoSuchFileException;
 
 import org.junit.Assert;
 import org.junit.BeforeClass;
@@ -114,7 +115,7 @@ public void testLookupForUser() throws IOException {
   public void testLookupForUserFileNotFound() throws Exception {
     TextFileBasedIdentityHandler handler =
         new TextFileBasedIdentityHandler(userMappingFile.getPath() + ".test", groupMappingFile.getPath());
-    intercept(FileNotFoundException.class, "FileNotFoundException",
+    intercept(NoSuchFileException.class, "NoSuchFileException",
         () -> handler.lookupForLocalUserIdentity(testUserDataLine3.split(":")[0]));
   }
 
@@ -143,7 +144,7 @@ public void testLookupForGroup() throws IOException {
   public void testLookupForGroupFileNotFound() throws Exception {
     TextFileBasedIdentityHandler handler =
         new TextFileBasedIdentityHandler(userMappingFile.getPath(), groupMappingFile.getPath() + ".test");
-    intercept(FileNotFoundException.class, "FileNotFoundException",
+    intercept(NoSuchFileException.class, "NoSuchFileException",
         () -> handler.lookupForLocalGroupIdentity(testGroupDataLine2.split(":")[0]));
   }
 }

@pjfanning
Copy link
Member Author

pjfanning commented Oct 5, 2023

Thanks @ayushtkn - I was looking independently and that looks like the right fix. The new commons-io code uses the safer java.nio APIs but these throw a different exception when files are missing.

@pjfanning pjfanning mentioned this pull request Oct 5, 2023
Merged
@pjfanning
Copy link
Member Author

pjfanning commented Oct 5, 2023

@ayushtkn I created #6152

pjfanning added a commit to pjfanning/hadoop that referenced this pull request Oct 12, 2023
@pjfanning
HADOOP-18917. Upgrade to commons-io 2.14.0 (apache#6133). Contributed…
222c150 
… by PJ Fanning

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
pjfanning added a commit to pjfanning/hadoop that referenced this pull request Oct 14, 2023
@pjfanning
HADOOP-18917. Upgrade to commons-io 2.14.0 (apache#6133). Contributed…
af83e63 
… by PJ Fanning

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
pjfanning added a commit to pjfanning/hadoop that referenced this pull request Oct 27, 2023
@pjfanning
HADOOP-18917. Upgrade to commons-io 2.14.0 (apache#6133). Contributed…
8a3f3ae 
… by PJ Fanning

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
ayushtkn pushed a commit that referenced this pull request Oct 30, 2023
@pjfanning
HADOOP-18917. Upgrade to commons-io 2.14.0 (#6133) (#6151). Contribut…
09c4f50 
…ed by PJ Fanning.
jiajunmao pushed a commit to jiajunmao/hadoop-MLEC that referenced this pull request Feb 6, 2024
@pjfanning @jiajunmao
HADOOP-18917. Upgrade to commons-io 2.14.0 (apache#6133). Contributed…
7c4c423 
… by PJ Fanning

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayushtkn ayushtkn ayushtkn approved these changes

Assignees

No one assigned

Labels

build trunk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pjfanning @hadoop-yetus @ayushtkn